Added results filename to write to if user does not specify path #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit adds the test requested in #159 . I know this should have been a separate PR but I had already pushed to this branch and the changes showed up. |
m8ttyB
reviewed
Nov 8, 2018
kimberlythegeek
approved these changes
Nov 9, 2018
kimberlythegeek
suggested changes
Nov 9, 2018
|
@kimberlythegeek flake8 error resolved. |
|
Merging this goodness, ty @terrameijar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kimberlythegeek I noticed a mistake that I made when coding this.
nameshould point to a user specified path, If it isNonethen we need to createresults.json. I had not added this in the last commit.